Correct way to 'break' code into lines

Coding
5

[QUOTE=Jeff Hanna;30266]I’d declare the lists outside of the call to formLayout.


formAttach = [(self.uiGrpField, 'left', 0), (self.uiClrBtn, 'left', 0), (self.uiLbl, 'left', 0),  (self.uiBtnOpt, 'left', 0), (self.uiBtnHelp, 'left', 0), (self.uiBtnReset, 'left', 0)]
controlAttach = [(self.uiSep, 'top', 5, self.uiBtnOpt), (self.uiSep, 'top', 5, self.uiBtnHelp), (self.uiSep, 'top', 5, self.uiBtnReset), (self.uiBtnOpt, 'left', 5, self.uiBtnHelp), (self.uiBtnReset, 'left', 5, self.uiBtnOpt)]

mc.formLayout(self.topForm, edit=True, attachForm=formAttach, attachControl=controlAttachList)

It’s much easier to read and if you needed to line-break you could cleanly do it after any of the comma separated values within the two lists.[/QUOTE]

If you want to take it further in the PEP8 direction…


formAttach = [
    (self.uiGrpField, 'left', 0),
    (self.uiClrBtn, 'left', 0),
    (self.uiLbl, 'left', 0),
    (self.uiBtnOpt, 'left', 0),
    (self.uiBtnHelp, 'left', 0),
    (self.uiBtnReset, 'left', 0)
]
controlAttach = [
    (self.uiSep, 'top', 5, self.uiBtnOpt),
    (self.uiSep, 'top', 5, self.uiBtnHelp),
    (self.uiSep, 'top', 5, self.uiBtnReset),
    (self.uiBtnOpt, 'left', 5, self.uiBtnHelp),
    (self.uiBtnReset, 'left', 5, self.uiBtnOpt)
]
mc.formLayout(self.topForm, edit=True, attachForm=formAttach,
    attachControl=controlAttachList)

I particularly like that style for lists in order to make it easier on the eyes when scanning.

More: PEP 8 – Style Guide for Python Code | peps.python.org

1 Like